[cmd/opampsupervisor] Conditionally use TLS config #35363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdb6986 to
00256ef
Compare
d5741d0 to
9635840
Compare
bacherfl
reviewed
Sep 26, 2024
BinaryFissionGames
approved these changes
Sep 26, 2024
|
@tigrannajaryan PTAL when you get a chance |
djaglowski
approved these changes
Sep 26, 2024
evan-bradley
approved these changes
Oct 2, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Fixes an issue where TLS would be used despite the opamp server using `ws` or `http` protocols. Before a TLS config would always get created, causing the connection to always use TLS settings. This change first checks which protocol we're using before creating a TLS config. **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#35283 **Testing:** <Describe what testing was performed and which tests were added.> Removed `tls.insecure_skip_verify: true` from e2e test configs which were using `ws` protocol since they are no longer needed. **Documentation:** <Describe the documentation added.>
|
@dpaasman00 Is this addressed i am still getting the same tls handshake error while using ws protocol 2024/10/24 07:23:38 Failed to connect to the server: tls: first record does not look like a TLS handshake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue where TLS would be used despite the opamp server using
wsorhttpprotocols.Before a TLS config would always get created, causing the connection to always use TLS settings. This change first checks which protocol we're using before creating a TLS config.
Link to tracking Issue: Fixes #35283
Testing:
Removed
tls.insecure_skip_verify: truefrom e2e test configs which were usingwsprotocol since they are no longer needed.Documentation: