[pkg/stanza] Don't get formatted msg for events without an event provider #35227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Sep 17, 2024
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
djaglowski
approved these changes
Sep 18, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ider (open-telemetry#35227) **Description:** When the event doesn't have a Publisher we should not rely on the behavior of `EvtFormatMessage` API, given, that in some cases it reports error. Instead we should fallback to the non-formatted message to avoid logging error messages on the collector. See issue open-telemetry#35135. **Link to tracking Issue:** Fix open-telemetry#35135 **Testing:** Local validation of the processing of the events reported in the issue. **Documentation:** N/A --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the event doesn't have a Publisher we should not rely on the behavior of
EvtFormatMessageAPI, given, that in some cases it reports error. Instead we should fallback to the non-formatted message to avoid logging error messages on the collector. See issue #35135.Link to tracking Issue:
Fix #35135
Testing:
Local validation of the processing of the events reported in the issue.
Documentation:
N/A