Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[chore] Force require.EventuallyWithT to fail properly" #35181

Closed
wants to merge 1 commit into from
Closed

Revert "[chore] Force require.EventuallyWithT to fail properly" #35181

wants to merge 1 commit into from

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Sep 13, 2024 •
edited
Loading

Reverts #35032 this is failing consistently on CI. cc @djaglowski

@pjanotti pjanotti requested review from a team and jpkrohling September 13, 2024 21:37
@github-actions github-actions bot requested a review from armstrmi September 13, 2024 21:37
@pjanotti
Copy link
Contributor Author

Closing it in favor of #35182 instead. cc @songy23

@pjanotti pjanotti closed this Sep 13, 2024
@pjanotti pjanotti deleted the revert-35032-wel-require-fail branch September 13, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@armstrmi armstrmi Awaiting requested review from armstrmi

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
receiver/windowseventlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjanotti @songy23 @MovieStoreGuy