[exporter/clickhouse] Update Trace SpanKind and StatusCode strings
#34799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dmitryax since you're the author of the other PRs/issues related to this. Thanks! |
Frapschen
approved these changes
Aug 22, 2024
mwear
approved these changes
Aug 26, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
open-telemetry#34799) **Description:** Trace `SpanKind` and `StatusCode` are exporting [old enum values](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/04b3b9898b242c0b3b707bc043c025eb9f6f73ba/internal/coreinternal/traceutil/traceutil.go#L13-L47). This change will make these fields consistent with the specification. I have marked this as a breaking change since it may affect queries that filter by these strings. There should be no change to exporter deployments, only to the read queries. See above/below links for more information as well as a sample of the old vs new values. Example: `STATUS_CODE_ERROR` -> `Error` **Link to tracking Issue:** - open-telemetry/opentelemetry-collector#6250 - open-telemetry/opentelemetry-collector#6251 **Testing:** - Updated integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Trace
SpanKindandStatusCodeare exporting old enum values. This change will make these fields consistent with the specification.I have marked this as a breaking change since it may affect queries that filter by these strings. There should be no change to exporter deployments, only to the read queries.
See above/below links for more information as well as a sample of the old vs new values.
Example:
STATUS_CODE_ERROR->ErrorLink to tracking Issue:
Testing: