-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hostmetricsreceiver): do not duplicate mountpoint metrics #34635
fix(hostmetricsreceiver): do not duplicate mountpoint metrics #34635
Conversation
Mountpoints can be reported multiple times for each mount into a namespace. This causes duplicate metrics which causes issues with some exporters. Each instance of the mountpoint will have identical metrics, so it is safe to ignore repeated mountpoints. Closes open-telemetry#34512
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question before I approve.
mountpoint: partition.Mountpoint, | ||
device: partition.Device, | ||
} | ||
if _, ok := seen[key]; partition.Mountpoint != "" && ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify to me why the check for Mountpoint being an empty string is here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Virtual partitions" test fails without that as virtual partitions don't have mount points. See test Include device filtering that includes virtual partitions
(I'm not really convinced about the validity of that particular feature/test, you get mount entries without devices, where only a filesystem type like procfs is used, but they do get mounted somewhere)
Please add a changelog. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@atoulme I added a change log a while back, any chance of a re-review? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@atoulme the checks didn't run last time this was ack'd, so I couldn't merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of codeowners, but someone with the right access will have to approve the test workflows.
@braydonk how can I make progress on this? Can you atleast remove the stale flag? Also, by the time anyone approves, I seem to need to end up rebasing/updating the branch, which then seems to need the tests re-run, so I feel a bit stuck. Am I doing something wrong, or do I just need to find someone "on the inside", to help this along? |
I do not have access to remove the However, according to the requirements this isn't fully approved even if the tests were to run. We still need approval from someone in @open-telemetry/collector-contrib-approvers. Someone from that group should have access, so since I've @'d hopefully one of them sees and does the things that require access here (remove Stale label, approve workflows, approve PR, merge). |
…elemetry#34635) Mountpoints can be reported multiple times for each mount into a namespace. This causes duplicate metrics which causes issues with some exporters. Each instance of the mountpoint will have identical metrics, so it is safe to ignore repeated mountpoints. Closes open-telemetry#34512 **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
…elemetry#34635) Mountpoints can be reported multiple times for each mount into a namespace. This causes duplicate metrics which causes issues with some exporters. Each instance of the mountpoint will have identical metrics, so it is safe to ignore repeated mountpoints. Closes open-telemetry#34512 **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
Mountpoints can be reported multiple times for each mount into a namespace. This causes duplicate metrics which causes issues with some exporters. Each instance of the mountpoint will have identical metrics, so it is safe to ignore repeated mountpoints.
Closes #34512
Description:
Link to tracking Issue:
Testing:
Documentation: