Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/logdedup] Make processor name consistent #34572

Merged

Conversation

MikeGoldsmith
Copy link
Member

Description:

Makes the processor name consistent.

Link to tracking Issue:

Testing:

Documentation:

@MikeGoldsmith MikeGoldsmith requested a review from a team August 9, 2024 15:05
@MikeGoldsmith MikeGoldsmith force-pushed the mike/consistent-logdedup-name branch from 0218657 to 6dc2fc5 Compare August 9, 2024 15:24
@djaglowski djaglowski merged commit cf88eb4 into open-telemetry:main Aug 9, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 9, 2024
@MikeGoldsmith MikeGoldsmith deleted the mike/consistent-logdedup-name branch August 9, 2024 15:46
dmitryax pushed a commit that referenced this pull request Aug 12, 2024
**Description:**
As a result of
#34585,
#34015,
and
#34572,
we've had some inconsistencies and incorrect information introduced
around code owners. This corrects these errors by updating
`metadata.yaml` to match the `CODEOWNERS` file, as well as updating
`CODEOWNERS` format, and adding a user to the `allowlist` of code owners
that are not OpenTelemetry members.

I believe there should be more discussion around adding people to the
`allowlist`, vs. simply not including as code owners until they become
members, but this change simply formats existing code owners, and
doesn't change anyone's current status.
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
…4572)

**Description:**

Makes the processor name consistent.

**Link to tracking Issue:**

- Closes open-telemetry#34571

**Testing:** 

**Documentation:**
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
**Description:**
As a result of
open-telemetry#34585,
open-telemetry#34015,
and
open-telemetry#34572,
we've had some inconsistencies and incorrect information introduced
around code owners. This corrects these errors by updating
`metadata.yaml` to match the `CODEOWNERS` file, as well as updating
`CODEOWNERS` format, and adding a user to the `allowlist` of code owners
that are not OpenTelemetry members.

I believe there should be more discussion around adding people to the
`allowlist`, vs. simply not including as code owners until they become
members, but this change simply formats existing code owners, and
doesn't change anyone's current status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make processor name consistent
3 participants