[processor/tailsampling] fix the behavior of inverse numeric filters #34416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
jpkrohling
reviewed
Aug 13, 2024
| { | ||
| Desc: "span attribute at the upper limit", | ||
| Trace: newTraceIntAttrs(empty, "example", math.MaxInt32), | ||
| Decision: Sampled, | ||
| }, | ||
| { | ||
| Desc: "resource attribute at the upper limit", | ||
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32}, "non_matching", math.MinInt32), |
There was a problem hiding this comment.
Suggested change
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32}, "non_matching", math.MinInt32), | |
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32}, "non_matching", math.MaxInt32), |
| }, | ||
| { | ||
| Desc: "resource attribute above max limit", | ||
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32 + 1}, "non_matching", math.MinInt32), |
There was a problem hiding this comment.
Suggested change
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32 + 1}, "non_matching", math.MinInt32), | |
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32 + 1}, "non_matching", math.MaxInt32), |
Or
Suggested change
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32 + 1}, "non_matching", math.MinInt32), | |
| Trace: newTraceIntAttrs(map[string]any{"example": math.MinInt32 + 1}, "non_matching", math.MinInt32), |
| }, | ||
| { | ||
| Desc: "resource attribute at the lower limit", | ||
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32}, "non_matching", math.MinInt32), |
There was a problem hiding this comment.
Suggested change
| Trace: newTraceIntAttrs(map[string]any{"example": math.MaxInt32}, "non_matching", math.MinInt32), | |
| Trace: newTraceIntAttrs(map[string]any{"example": math.MinInt32}, "non_matching", math.MinInt32), |
There was a problem hiding this comment.
Actually, there's already a test a few line above with the same name. I wonder if they are the same?
There was a problem hiding this comment.
thanks for spotting this - in this case the name of the test is misleading as it should be resource attribute at upper limit - will fix that
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
jpkrohling
approved these changes
Aug 19, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…pen-telemetry#34416) **Description:** This PR fixes the behaviour of numeric attribute filters with the `inverse_match` option set to `true`. In this case, the numeric filter now returns `InvertNotSampled`/`InvertSampled` if its condition matches, to make sure a span with matching attributes is not sampled even though other policies might yield a `Sampled` result. **Link to tracking Issue:** open-telemetry#34296 **Testing:** Added unit tests **Documentation:** No changes here, as the expected behavior is already described in the docs --------- Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR fixes the behaviour of numeric attribute filters with the
inverse_matchoption set totrue. In this case, the numeric filter now returnsInvertNotSampled/InvertSampledif its condition matches, to make sure a span with matching attributes is not sampled even though other policies might yield aSampledresult.Link to tracking Issue: #34296
Testing: Added unit tests
Documentation: No changes here, as the expected behavior is already described in the docs