Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change obsreport receiver calling pattern in awsxrayreceiver #3439

Merged
merged 1 commit into from
May 20, 2021
Merged

Change obsreport receiver calling pattern in awsxrayreceiver #3439

merged 1 commit into from
May 20, 2021

Conversation

humivo
Copy link
Member

@humivo humivo commented May 20, 2021

Description: Change obsreport helpers for receiver to use the new pattern created in Collector. Specifically for awsxrayreceiver.

Link to tracking Issue: Issue #3436

@humivo humivo requested a review from a team May 20, 2021 17:39
@jpkrohling
Copy link
Member

jpkrohling commented May 20, 2021 •
edited
Loading

Test TestLog10kDPS/OTLP failed with:

2021/05/20 17:51:56 CPU consumption is 58.3%, max expected is 35%
    test_case.go:334: CPU consumption is 58.3%, max expected is 35%

Triggering a new run.

@humivo
Copy link
Member Author

humivo commented May 20, 2021

Test TestLog10kDPS/OTLP failed with:

2021/05/20 17:51:56 CPU consumption is 58.3%, max expected is 35%
    test_case.go:334: CPU consumption is 58.3%, max expected is 35%

Triggering a new run.

Thank you! Seems good now

@bogdandrutu bogdandrutu merged commit 8bb714e into open-telemetry:main May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@kbrockhoff kbrockhoff Awaiting requested review from kbrockhoff

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humivo @jpkrohling @bogdandrutu