Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][receiver/chrony]: replace github.com/tilinna/clock with github.com/jonboulle/clockwork #34221

Merged
merged 5 commits into from
Jul 23, 2024
Merged

[chore][receiver/chrony]: replace github.com/tilinna/clock with github.com/jonboulle/clockwork #34221

merged 5 commits into from
Jul 23, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jul 23, 2024 •
edited
Loading

Description:

  • replaces github.com/tilinna/clock with github.com/jonboulle/clockwork in chrony receiver

Link to tracking Issue: #34190

Connected PRs:

Notes:

The failing check is not caused by changes in this PR, it's a flaky test #33865

@odubajDT odubajDT changed the title [chore]: replace github.com/tilinna/clock with github.com/jonboulle/clockwork [chore]: replace github.com/tilinna/clock with github.com/jonboulle/clockwork Jul 23, 2024
ChrsMark
ChrsMark reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this only changes the chronyreceiver (+1 on having different PRs for the various components of #34190). Could we explicitly mention it in the title of the PR to easily keep track of the related patches?

@odubajDT
Copy link
Contributor Author

I see this only changes the chronyreceiver (+1 on having different PRs for the various components of #34190). Could we explicitly mention it in the title of the PR to easily keep track of the related patches?

Thanks! The PR is not completely ready for review yet, that's why it's still in draft mode, but will add a description!

@odubajDT odubajDT changed the title [chore]: replace github.com/tilinna/clock with github.com/jonboulle/clockwork [chore][receiver/chrony]: replace github.com/tilinna/clock with github.com/jonboulle/clockwork Jul 23, 2024
This was referenced Jul 23, 2024
Merged
Merged
@odubajDT odubajDT marked this pull request as ready for review July 23, 2024 12:03
@odubajDT odubajDT requested a review from a team July 23, 2024 12:03
odubajDT added 3 commits July 23, 2024 14:25
@odubajDT
[chore]: replace github.com/tilinna/clock with github.com/jonboulle/c…
d71a1c6 
…lockwork

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
polish
8e70256 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
go mod tidy
e62b746 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT added 2 commits July 23, 2024 14:25
@odubajDT
go mod tidy
e21d7f4 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix test
8544d62 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT requested a review from ChrsMark July 23, 2024 12:51
djaglowski pushed a commit that referenced this pull request Jul 23, 2024
@odubajDT
[chore][extensions/jaegerremotesampling]: replace `github.com/tilinna…
5d772df 
…/clock` with `github.com/jonboulle/clockwork` (#34224)

**Description:**
- replaces `github.com/tilinna/clock` with
`github.com/jonboulle/clockwork` in `jaegerremotesampleing extension`

**Link to tracking Issue:**
#34190

**Connected PRs:**
-
#34221
-
#34226

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@djaglowski djaglowski merged commit 5f7025a into open-telemetry:main Jul 23, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 23, 2024
djaglowski pushed a commit that referenced this pull request Jul 24, 2024
@odubajDT
[chore][connector/spanmetrics]: replace github.com/tilinna/clock wi…
d5c40d3 
…th `github.com/jonboulle/clockwork` (#34226)

**Description:**
- replaces `github.com/tilinna/clock` with
`github.com/jonboulle/clockwork` in `spanmetrics connector`

**Link to tracking Issue:**
#34190

**Connected PRs:**
-
#34221
-
#34224

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@djaglowski djaglowski mentioned this pull request Jul 24, 2024
Closed
@odubajDT odubajDT mentioned this pull request Aug 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@Frapschen Frapschen Awaiting requested review from Frapschen

@frzifus frzifus Awaiting requested review from frzifus

@jamesmoessis jamesmoessis Awaiting requested review from jamesmoessis

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@portertech portertech Awaiting requested review from portertech

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

@carsonip carsonip Awaiting requested review from carsonip

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

@ycombinator ycombinator Awaiting requested review from ycombinator

@ChrsMark ChrsMark Awaiting requested review from ChrsMark

Assignees

@evan-bradley evan-bradley

Labels
cmd/otelcontribcol otelcontribcol command connector/spanmetrics exporter/elasticsearch extension/jaegerremotesampling receiver/chrony testbed
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging this pull request may close these issues.
4 participants
@odubajDT @djaglowski @ChrsMark @evan-bradley