Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginx metrics and tests #3420

Merged
merged 4 commits into from
May 20, 2021
Merged

Update nginx metrics and tests #3420

merged 4 commits into from
May 20, 2021

Conversation

dehaansa
Copy link
Contributor

Description: Update the nginx metrics to more closely align with the conventions. Also enhanced the unit & integration tests to validate.

Issue: #3390

@dehaansa dehaansa requested a review from a team May 18, 2021 14:25
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 18, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

djaglowski
djaglowski approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion on the integration test.

receiver/nginxreceiver/integration_test.go Outdated Show resolved Hide resolved
@bogdandrutu
Copy link
Member

/cc @jrcamp

jrcamp
jrcamp suggested changes May 18, 2021
View reviewed changes
receiver/nginxreceiver/metadata.yaml Show resolved Hide resolved
receiver/nginxreceiver/scraper.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit f89ebd2 into open-telemetry:main May 20, 2021
@dehaansa dehaansa deleted the nginx-integration-test-metrics branch May 20, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@jrcamp jrcamp jrcamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dehaansa @bogdandrutu @jrcamp @djaglowski