Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [pkg/stanza] Mock time functions for flaky TestExcludeOlderThanFilter #34174

Merged

Conversation

ChrsMark
Copy link
Member

Description:

Similar to #34128. Mocking the time functions to fix flakiness on windows.

Link to tracking Issue: #32838

Testing:

Documentation:

@github-actions github-actions bot requested a review from djaglowski July 19, 2024 14:37
@ChrsMark ChrsMark force-pushed the fix_TestExcludeOlderThanFilter_windows branch from ba41cdd to c1e63f9 Compare July 19, 2024 14:56
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jul 19, 2024
@ChrsMark ChrsMark force-pushed the fix_TestExcludeOlderThanFilter_windows branch 2 times, most recently from 2c7c13f to 9f332c1 Compare July 19, 2024 15:10
@djaglowski djaglowski added the Run Windows Enable running windows test on a PR label Jul 19, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the fix_TestExcludeOlderThanFilter_windows branch from 9f332c1 to 0f50255 Compare July 22, 2024 08:17
@ChrsMark ChrsMark marked this pull request as ready for review July 22, 2024 08:55
@ChrsMark ChrsMark requested a review from a team July 22, 2024 08:55
@djaglowski djaglowski merged commit 6a4d7cd into open-telemetry:main Jul 23, 2024
172 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants