Nginx integration test #3377
Merged
Nginx integration test #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase and run |
All set 👍 |
bogdandrutu
approved these changes
May 12, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
… calls (#3377) Fixes couple of bugs from PR#3322, see comments in that PR. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some receivers have integration tests leveraging Docker containers. This PR adds Nginx integration testing following that same pattern. This implementation is inspired by jmxreceiver's integration tests.
The test will:
TODO: These could be handled in future pull requests. I would like to receive some feedback or direction before proceeding.
Link to tracking Issue:
resolves #3376
Testing:
Testing with a valid Nginx config is successful. Removing the /status endpoint from Nginx (disabling metrics) will cause the test to fail.
Documentation:
No documentation was added. These tests run with the existing
make integration-tests-with-covercommand.