-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AzureDataExplorerExporter: add support for WorkloadIdentity #33668
Improve AzureDataExplorerExporter: add support for WorkloadIdentity #33668
Conversation
|
Azure Identity supports WorkloadIdentity for authenticating workloads running in Kubernetes to Azure resources. This improvement targets workloads that want to export telemetry from Kubernetes pods to Azure Data Explorer, and those pods use a service account that is bound to an Azure managed identity.
0e1509e
to
9e29d7c
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
I received an automated notification informing me this issue was at risk of being automatically closed for lack of activity. Would the pending reviewers please comment on the status of this PR, does it need to be retracted, does it need additional work? Thank you. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@asaharn @ag-ramachandran could one of you please take a look? |
Thanks @evan-bradley , having a look. Will add comments to the PR by tomorrow |
Hello @evan-bradley Looks good, was this tested on a WIF based environment like AKS |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
@mipnw could you complete this PR. Thanks. |
@SatyKrish I'm not sure what you're asking me to do. I don't have permission to merge this I'm not a maintainer on this repo. I don't see any comments inside the PR. I see @ag-ramachandran asked if this was tested in a WIF environment. I honestly no longer remember what testing I did for this, I submitted this PR months ago and any status I would have written inside the PR at the time. I had access to a Kusto cluster at the time. I no longer do and I no longer have bandwidth to re run the testing. |
Description: Add support for WorkloadIdentity in exporter/azuredataexplorerexporter
Link to tracking Issue: 33667
Testing:
make
Documentation: edited the README.md for that exporter.