Update stackdriver expoerter to v0.13.6 in google cloud exporters #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
May 10, 2021
punya
approved these changes
May 10, 2021
|
Please rebase, then run |
…ogle cloud exporters
|
@bogdandrutu done |
dashpole
commented
May 10, 2021
| @@ -141,7 +141,7 @@ func TestResourceMapper(t *testing.T) { | |||
| }, | |||
| // Resource without matching config should be converted via default implementation | |||
| wantResource: &monitoredres.MonitoredResource{ | |||
| Type: "global", | |||
| Type: "generic_task", | |||
There was a problem hiding this comment.
Note that this behavior was a bug, and was fixed by census-ecosystem/opencensus-go-exporter-stackdriver#286
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Go development practices favors returning concrete types over interfaces, so the users don't have to force cast the return value to the concrete type and the APIs self document the returned error type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update contains census-ecosystem/opencensus-go-exporter-stackdriver#287, which should prevent open-telemetry/opentelemetry-collector#3047 from breaking google cloud exporters.
@punya