[extension/observer] Expose host and port independently in endpoint env #33572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Jun 14, 2024
Comment on lines
+235
to
+236
| "host": "127.0.0.1", | ||
| "port": "1234", |
There was a problem hiding this comment.
This is the test case that ensures the Target gets properly parsed as host and port.
dmitryax
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The observer extension currently only exposes
endpointin its endpoint environment that is made available to the receiver creator for dynamically configuring receivers. Some receivers requirehostandportto be configured separately, soendpointcontaining both is incompatible with those receivers. Exposing these independently allows the receiver creator to be compatible with those receivers.Link to tracking Issue:
Resolves #33571
Testing:
Added testing, existing testing passes
Documentation:
Added example usage in receiver creator README.