Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl]: Add ByteSliceLikeGetter interface #33536

Merged
merged 6 commits into from
Jun 21, 2024
Merged

[pkg/ottl]: Add ByteSliceLikeGetter interface #33536

merged 6 commits into from
Jun 21, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jun 13, 2024 •
edited
Loading

Description:
Adds ByteSliceLikeGetter interface due to future support of Hex() converter

Link to tracking Issue: #31929

Testing:

Documentation:

@odubajDT odubajDT mentioned this pull request Jun 13, 2024
Merged
odubajDT added 2 commits June 13, 2024 10:57
@odubajDT
[pkg/ottl]: Add ByteSliceLikeGetter interface
71faa64 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
add chlog
e85589e 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT force-pushed the add-byteslicelikegetter branch from db581c1 to 3ab6d09 Compare June 13, 2024 08:58
@odubajDT odubajDT marked this pull request as ready for review June 13, 2024 08:59
@odubajDT odubajDT requested a review from a team June 13, 2024 08:59
@odubajDT odubajDT force-pushed the add-byteslicelikegetter branch from 3ab6d09 to e85589e Compare June 13, 2024 09:35
@odubajDT
fix lint
9baaf26 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
evan-bradley
evan-bradley reviewed Jun 14, 2024
View reviewed changes
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression_test.go Outdated Show resolved Hide resolved
@odubajDT
pr review
fb4be44 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
evan-bradley
evan-bradley approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
@evan-bradley
Copy link
Contributor

@TylerHelmuth please take a look.

TylerHelmuth
TylerHelmuth reviewed Jun 14, 2024
View reviewed changes
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/functions.go Show resolved Hide resolved
@evan-bradley
Copy link
Contributor

@odubajDT Could you look at using encoding/binary.Write to do the translation to []byte? I didn't realize that package existed before, but I think that may be a better way to go.

@odubajDT
use encoding/binary lib
2c03e8b 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
Copy link
Contributor Author

@odubajDT Could you look at using encoding/binary.Write to do the translation to []byte? I didn't realize that package existed before, but I think that may be a better way to go.

Adapted!

@odubajDT
polishing
affc438 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@evan-bradley evan-bradley merged commit 0bf1a75 into open-telemetry:main Jun 21, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 21, 2024
evan-bradley pushed a commit that referenced this pull request Jul 3, 2024
@odubajDT
[pkg/ottl] Add Hex() convertor (#33450)
4e91206 
**Description:** <Describe what has changed.>
Adds a Hex function to the OTTL package. This function can be applied to
following values:

- float64
- string
- bool
- int64
- []byte

The resulting value will be of type []byte.

**Link to tracking Issue:**
#31929

**Testing:**
- unit tests
- e2e tests

Depends on
#33536

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT mentioned this pull request Aug 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@evan-bradley evan-bradley evan-bradley approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@dmitryax dmitryax

Labels
pkg/ottl
Projects
None yet
Milestone
v0.104.0
Development

Successfully merging this pull request may close these issues.
4 participants
@odubajDT @evan-bradley @TylerHelmuth @dmitryax