Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map summary metrics to Splunk hec metrics #3344

Merged
merged 2 commits into from
May 11, 2021
Merged

Map summary metrics to Splunk hec metrics #3344

merged 2 commits into from
May 11, 2021

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented May 7, 2021

Description:
Adds mapping of the summary data type to Splunk HEC metrics.

Link to tracking Issue:
#3319

Testing:
One unit test.

@atoulme atoulme requested a review from a team May 7, 2021 22:02
dmitryax
dmitryax approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu
Copy link
Member

Please update PR title to more verbose sentence :)

@atoulme atoulme changed the title Add summary Map summary metrics to Splunk hec metrics May 10, 2021
@atoulme
Copy link
Contributor Author

atoulme commented May 10, 2021

Sure, done.

@bogdandrutu
Copy link
Member

Please rebase

@bogdandrutu
Copy link
Member

@atoulme this seems related to your change:

running go unit test ./... + coverage in /home/circleci/project/exporter/splunkhecexporter
--- FAIL: Test_metricDataToSplunk (0.01s)
    --- FAIL: Test_metricDataToSplunk/double_gauge_empty_data_point (0.00s)
        metricdata_to_splunk_test.go:622: 
            	Error Trace:	metricdata_to_splunk_test.go:622
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	Test_metricDataToSplunk/double_gauge_empty_data_point
    --- FAIL: Test_metricDataToSplunk/int_gauge_empty_data_point (0.00s)
        metricdata_to_splunk_test.go:622: 
            	Error Trace:	metricdata_to_splunk_test.go:622
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	Test_metricDataToSplunk/int_gauge_empty_data_point
    --- FAIL: Test_metricDataToSplunk/int_histogram_empty_data_point (0.00s)
        metricdata_to_splunk_test.go:622: 
            	Error Trace:	metricdata_to_splunk_test.go:622
            	Error:      	Not equal: 
            	            	expected: 2
            	            	actual  : 0
            	Test:       	Test_metricDataToSplunk/int_histogram_empty_data_point
    --- FAIL: Test_metricDataToSplunk/double_histogram_empty_data_point (0.00s)
        metricdata_to_splunk_test.go:622: 
            	Error Trace:	metricdata_to_splunk_test.go:622
            	Error:      	Not equal: 
            	            	expected: 2
            	            	actual  : 0
            	Test:       	Test_metricDataToSplunk/double_histogram_empty_data_point
    --- FAIL: Test_metricDataToSplunk/int_sum_empty_data_point (0.00s)
        metricdata_to_splunk_test.go:622: 
            	Error Trace:	metricdata_to_splunk_test.go:622
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	Test_metricDataToSplunk/int_sum_empty_data_point
    --- FAIL: Test_metricDataToSplunk/double_sum_empty_data_point (0.00s)
        metricdata_to_splunk_test.go:622: 
            	Error Trace:	metricdata_to_splunk_test.go:622
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	Test_metricDataToSplunk/double_sum_empty_data_point
    --- FAIL: Test_metricDataToSplunk/double_histogram_no_upper_bound (0.00s)
        metricdata_to_splunk_test.go:622: 
            	Error Trace:	metricdata_to_splunk_test.go:622
            	Error:      	Not equal: 
            	            	expected: 2
            	            	actual  : 0
            	Test:       	Test_metricDataToSplunk/double_histogram_no_upper_bound
    --- FAIL: Test_metricDataToSplunk/int_histogram_no_upper_bound (0.00s)
        metricdata_to_splunk_test.go:622: 
            	Error Trace:	metricdata_to_splunk_test.go:622
            	Error:      	Not equal: 
            	            	expected: 2
            	            	actual  : 0
            	Test:       	Test_metricDataToSplunk/int_histogram_no_upper_bound

@atoulme
Copy link
Contributor Author

atoulme commented May 10, 2021

Fixed. Rerunning CI.

@bogdandrutu bogdandrutu merged commit 63796d8 into open-telemetry:main May 11, 2021
@atoulme atoulme deleted the add_summary branch May 11, 2021 16:06
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@dependabot
Bump go.uber.org/zap from 1.16.0 to 1.17.0 in /cmd/issuegenerator (#3344
1f7c661 
)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.16.0...v1.17.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees

@dmitryax dmitryax

Labels
waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atoulme @bogdandrutu @dmitryax