Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/elasticsearch] remove multierr from elasticsearch receiver #33052

Merged
merged 5 commits into from
May 16, 2024
Merged

[receiver/elasticsearch] remove multierr from elasticsearch receiver #33052

merged 5 commits into from
May 16, 2024

Conversation

rogercoll
Copy link
Contributor

Description:
Replace multierr in favor of errors.Join

Link to tracking Issue:
#25121

Testing:

Documentation:

@rogercoll rogercoll requested a review from djaglowski as a code owner May 14, 2024 16:57
@rogercoll rogercoll requested a review from a team May 14, 2024 16:57
@rogercoll
Copy link
Contributor Author

Skip changelog?

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 14, 2024
crobert-1
crobert-1 approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is frequency of #27295, unrelated to this change.

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label May 14, 2024
@andrzej-stencel andrzej-stencel removed the ready to merge Code review completed; ready to merge by maintainers label May 15, 2024
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label May 15, 2024
@andrzej-stencel andrzej-stencel merged commit 4b9a237 into open-telemetry:main May 16, 2024
169 checks passed
@github-actions github-actions bot added this to the next release milestone May 16, 2024
@rogercoll rogercoll deleted the elasticsearch-remove-multierr branch May 16, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@songy23 songy23 songy23 approved these changes

@djaglowski djaglowski djaglowski approved these changes

@BinaryFissionGames BinaryFissionGames Awaiting requested review from BinaryFissionGames

Assignees

@bogdandrutu bogdandrutu

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/elasticsearch Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.101.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rogercoll @djaglowski @songy23 @crobert-1 @bogdandrutu @andrzej-stencel