[exporter/elasticsearch] Extend integration tests to cover traces #32512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
approved these changes
Apr 18, 2024
crobert-1
approved these changes
Apr 18, 2024
exporter/elasticsearchexporter/integrationtest/exporter_test.go
Outdated
Show resolved
Hide resolved
carsonip
approved these changes
Apr 22, 2024
|
Failing unit test is frequency of #32391, I've added a reference there. It's unrelated to this change. |
ycombinator
reviewed
Apr 23, 2024
exporter/elasticsearchexporter/integrationtest/exporter_test.go
Outdated
Show resolved
Hide resolved
|
[For reviewers] I have added a disclaimer to the PR about how |
ycombinator
approved these changes
Apr 26, 2024
carsonip
approved these changes
Apr 27, 2024
codeboten
approved these changes
May 1, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Enable integration tests for both traces and logs, previously only logs were tested.
Link to tracking Issue: N/A
Testing:
cd exporter/elasticsearchexporter/integrationtest && make testDocumentation: N/A