Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] update mdatagen #32499

Merged
merged 9 commits into from
Apr 22, 2024
Merged

[chore] update mdatagen #32499

merged 9 commits into from
Apr 22, 2024

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Apr 17, 2024 •
edited
Loading

This PR pulls in the latest mdatagen that auto-generates goleak package tests. There are still some issues to sort out before being able to use it, but it's mostly there.

I've found a few more modules where goleak can be enabled with no additional tests so i've done so as part of this PR

Fixes #30483

@codeboten codeboten requested a review from a team April 17, 2024 22:55
@codeboten
skip pulsar goleak tests
3cae7b4 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
tidy & generate
4645009 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
ensure code is gofmt'd after generate
c85b1d6 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
few more modules that need skipping
6b587f7 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
tidy
5ad628f 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten merged commit 78b852c into open-telemetry:main Apr 22, 2024
156 checks passed
@codeboten codeboten deleted the codeboten/update-mdatagen branch April 22, 2024 14:50
@github-actions github-actions bot added this to the next release milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth left review comments

@songy23 songy23 songy23 approved these changes

@dmitryax dmitryax dmitryax approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@yurishkuro yurishkuro Awaiting requested review from yurishkuro yurishkuro is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@bryan-aguilar bryan-aguilar Awaiting requested review from bryan-aguilar

Assignees

@dashpole dashpole

Labels
cmd/configschema configschema command cmd/githubgen cmd/opampsupervisor cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol cmd/telemetrygen telemetrygen command confmap/provider/s3provider confmap/provider/secretsmanagerprovider connector/count connector/datadog connector/exceptions connector/failover connector/grafanacloud connector/routing connector/servicegraph connector/spanmetrics exporter/alertmanager exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/carbon exporter/cassandra exporter/clickhouse exporter/coralogix exporter/datadog Datadog components exporter/dataset exporter/elasticsearch exporter/file exporter/googlecloud exporter/googlecloudpubsub exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/honeycombmarker exporter/influxdb exporter/instana exporter/kafka exporter/kinetica exporter/loadbalancing exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/opencensus exporter/opensearch exporter/otelarrow exporter/prometheus exporter/prometheusremotewrite exporter/pulsar exporter/rabbitmq exporter/sapm exporter/sentry exporter/signalfx exporter/skywalking exporter/splunkhec exporter/sumologic exporter/syslog exporter/tencentcloudlogservice exporter/zipkin extension/ack extension/asapauth extension/awsproxy extension/basicauth extension/bearertokenauth
Projects
None yet
Milestone
v0.99.0
Development

Successfully merging this pull request may close these issues.

[mdatagen] Automatically generate goleak tests for packages
5 participants
@codeboten @dmitryax @songy23 @TylerHelmuth @dashpole