Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][receiver/purefb] Enable goleak check #32184

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

crobert-1
Copy link
Member

Description:

This change enables goleak checks on the Pure Storage FlashBlade receiver to help ensure no goroutines are being leaked. This is a test only change as a test was missing a shutdown call.

This looks like I deleted a test, but the two tests were identical, other than a missing shutdown call. Once the missing call was added they were identical, so I decided to delete one. I also consolidated err checking to remove the err variable and directly check the result of the Start and Shutdown methods.

Link to tracking Issue:
#30438

Testing:
All existing tests are passing, as well as added goleak check.

@crobert-1 crobert-1 requested a review from jpkrohling as a code owner April 4, 2024 23:36
@crobert-1 crobert-1 requested a review from a team April 4, 2024 23:36
@codeboten codeboten merged commit 9f3db69 into open-telemetry:main Apr 5, 2024
143 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants