Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS certs verification for Splunk HEC exporter #3204

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Add TLS certs verification for Splunk HEC exporter #3204

merged 1 commit into from
Apr 27, 2021

Conversation

chaitanyaphalak
Copy link
Contributor

Description: Adds support for TLS certificate verification while use splunk hec exporter

Link to tracking Issue: #3015

Testing: Tested on localhost

Documentation: Add documentation for new/replaced configuration options

@chaitanyaphalak chaitanyaphalak requested a review from a team April 21, 2021 23:42
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Chaitanya Phalak (870117e605eed05a0a7e46c254f9f727e6df5e93)

@bogdandrutu
Copy link
Member

@chaitanyaphalak please sign the CLA

jrcamp
jrcamp suggested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@jrcamp jrcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, was just looking into it recently. Would be great to use HTTPClientSettings eventually but that may require some changes to core. This shouldn't make moving to HTTPClientSettings any harder so I think it's a good improvement for now.

exporter/splunkhecexporter/exporter.go Outdated Show resolved Hide resolved
exporter/splunkhecexporter/README.md Outdated Show resolved Hide resolved
@chaitanyaphalak chaitanyaphalak force-pushed the add-tls-certs-splunk-hec-exporter branch 3 times, most recently from ccd7c45 to cefe441 Compare April 22, 2021 19:44
jrcamp
jrcamp suggested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@jrcamp jrcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaitanyaphalak looks like tests still failing though

@chaitanyaphalak chaitanyaphalak force-pushed the add-tls-certs-splunk-hec-exporter branch 3 times, most recently from 516d081 to 7cb3f49 Compare April 23, 2021 20:38
@chaitanyaphalak chaitanyaphalak force-pushed the add-tls-certs-splunk-hec-exporter branch from 7cb3f49 to d64c672 Compare April 27, 2021 16:48
@chaitanyaphalak chaitanyaphalak mentioned this pull request Apr 27, 2021
Closed
@chaitanyaphalak chaitanyaphalak force-pushed the add-tls-certs-splunk-hec-exporter branch from d64c672 to e94ce2e Compare April 27, 2021 17:08
@chaitanyaphalak chaitanyaphalak force-pushed the add-tls-certs-splunk-hec-exporter branch from e94ce2e to 2105d44 Compare April 27, 2021 19:25
@chaitanyaphalak
Copy link
Contributor Author

@jrcamp all the tests/checks have passed, we should merge this :) I cant merge it :)

@tigrannajaryan tigrannajaryan merged commit 8602820 into open-telemetry:main Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrcamp jrcamp jrcamp approved these changes

Assignees

@jrcamp jrcamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaitanyaphalak @bogdandrutu @jrcamp @tigrannajaryan