Use the correct default for aws_auth.service for the AWS PRW exporter #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3161 +/- ##
==========================================
- Coverage 91.92% 91.91% -0.02%
==========================================
Files 494 494
Lines 23962 23960 -2
==========================================
- Hits 22028 22022 -6
- Misses 1428 1430 +2
- Partials 506 508 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@anuraaga, can you take a look? |
anuraaga
reviewed
Apr 20, 2021
rakyll
commented
Apr 20, 2021
|
@anuraaga is the test coverage a blocker here? We can do a follow up to improve code coverage in this package. The coverage results are not introduced by this change, they were historically low. |
anuraaga
approved these changes
Apr 22, 2021
"aps" is currently the only value that is acceptable for this field. We should have never provided it as a configuration setting but we can't remove and break the existing users. This change is setting it to "aps" by default. A follow up change will be provided to automatically parse the region from the workspace remote write endpoint.
|
@anuraaga Rebased this, now the build-push is passing. You can merge it. |
|
I can't merge but @bogdandrutu can :) |
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…open-telemetry#3161) * Use the correct default for aws_auth.region for the AWS PRW exporter "aps" is currently the only value that is acceptable for this field. We should have never provided it as a configuration setting but we can't remove and break the existing users. This change is setting it to "aps" by default. A follow up change will be provided to automatically parse the region from the workspace remote write endpoint. * Reorder * Improve godoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"aps" is currently the only value that is acceptable for this field. We should have never provided it as a configuration setting but we can't remove and break the existing users. This change is setting it to "aps" by default.
A follow-up change will be provided to automatically parse the region from the workspace remote write endpoint.