[chore][exporter/splunkhecexporter] Enable goleak check

exporter/splunkhecexporter/client_test.go

@@ -236,6 +236,8 @@ func runMetricsExport(cfg *Config, metrics pmetric.Metrics, expectedBatchesNum i
 	assert.NoError(t, err)
 	assert.NoError(t, exporter.Start(context.Background(), componenttest.NewNopHost()))
 	defer func() {
+		// Read from channel so that the goroutine running the send operation can exit successfully
+		_ = <-capture.receivedRequest
 		assert.NoError(t, exporter.Shutdown(context.Background()))
 	}()
 
@@ -1396,6 +1398,9 @@ func TestHeartbeatStartupFailed(t *testing.T) {
 	assert.NoError(t, err)
 	// The exporter's name is "" while generating default params
 	assert.EqualError(t, exporter.Start(context.Background(), componenttest.NewNopHost()), ": heartbeat on startup failed: HTTP 403 \"Forbidden\"")
+	// Read from channel so that the goroutine running the send operation can exit successfully
+	_ = <-capture.receivedRequest
+	assert.NoError(t, exporter.Shutdown(context.Background()))
 }
 
 func TestHeartbeatStartupPass_Disabled(t *testing.T) {
@@ -1431,6 +1436,7 @@ func TestHeartbeatStartupPass_Disabled(t *testing.T) {
 	exporter, err := factory.CreateTracesExporter(context.Background(), params, cfg)
 	assert.NoError(t, err)
 	assert.NoError(t, exporter.Start(context.Background(), componenttest.NewNopHost()))
+	assert.NoError(t, exporter.Shutdown(context.Background()))
 }
 
 func TestHeartbeatStartupPass(t *testing.T) {
@@ -1466,6 +1472,9 @@ func TestHeartbeatStartupPass(t *testing.T) {
 	exporter, err := factory.CreateTracesExporter(context.Background(), params, cfg)
 	assert.NoError(t, err)
 	assert.NoError(t, exporter.Start(context.Background(), componenttest.NewNopHost()))
+	// Read from channel so that the goroutine running the send operation can exit successfully
+	_ = <-capture.receivedRequest
+	assert.NoError(t, exporter.Shutdown(context.Background()))
 }
 
 type badJSON struct {

exporter/splunkhecexporter/go.mod

@@ -25,6 +25,7 @@ require (
 	go.opentelemetry.io/collector/semconv v0.93.1-0.20240130182548-89388addcc7f
 	go.opentelemetry.io/otel/metric v1.22.0
 	go.opentelemetry.io/otel/trace v1.22.0
+	go.uber.org/goleak v1.3.0
 	go.uber.org/multierr v1.11.0
 	go.uber.org/zap v1.26.0
 	gopkg.in/yaml.v3 v3.0.1

exporter/splunkhecexporter/integration_test.go

@@ -10,7 +10,6 @@ import (
 	"crypto/tls"
 	"fmt"
 	"net/http"
-	"os"
 	"os/exec"
 	"strconv"
 	"testing"
@@ -74,17 +73,6 @@ func teardown(cfg SplunkContainerConfig) {
 	fmt.Printf("Command output:\n%s\n", output)
 }
 
-func TestMain(m *testing.M) {
-	splunkContCfg := setup()
-
-	// Run the tests
-	code := m.Run()
-
-	teardown(splunkContCfg)
-	// Exit with the test result code
-	os.Exit(code)
-}
-
 func createInsecureClient() *http.Client {
 	// Create a custom transport with insecure settings
 	tr := &http.Transport{
@@ -223,6 +211,9 @@ func prepareTracesData(index string, source string, sourcetype string) ptrace.Tr
 }
 
 func TestSplunkHecExporterEventsToSplunk(t *testing.T) {
+	splunkContCfg := setup()
+	defer teardown(splunkContCfg)
+
 	logger := zaptest.NewLogger(t)
 	logger.Info("Test -> Splunk running at:", zap.String("host", integrationtestutils.GetConfigVariable("HOST")),
 		zap.String("uiPort", integrationtestutils.GetConfigVariable("UI_PORT")),
@@ -266,6 +257,9 @@ func TestSplunkHecExporterEventsToSplunk(t *testing.T) {
 }
 
 func TestSplunkHecExporterEventsToSplunkNonDefaultIndex(t *testing.T) {
+	splunkContCfg := setup()
+	defer teardown(splunkContCfg)
+
 	logger := zaptest.NewLogger(t)
 	logger.Info("Test -> Splunk running at:", zap.String("host", integrationtestutils.GetConfigVariable("HOST")),
 		zap.String("uiPort", integrationtestutils.GetConfigVariable("UI_PORT")),
@@ -315,6 +309,9 @@ func TestSplunkHecExporterEventsToSplunkNonDefaultIndex(t *testing.T) {
 }
 
 func TestSplunkHecExporterMetricsToSplunk(t *testing.T) {
+	splunkContCfg := setup()
+	defer teardown(splunkContCfg)
+
 	logger := zaptest.NewLogger(t)
 	logger.Info("Test -> Splunk running at:", zap.String("host", integrationtestutils.GetConfigVariable("HOST")),
 		zap.String("uiPort", integrationtestutils.GetConfigVariable("UI_PORT")),
@@ -350,6 +347,9 @@ func TestSplunkHecExporterMetricsToSplunk(t *testing.T) {
 }
 
 func TestSplunkHecExporterTracesToSplunk(t *testing.T) {
+	splunkContCfg := setup()
+	defer teardown(splunkContCfg)
+
 	logger := zaptest.NewLogger(t)
 	logger.Info("Test -> Splunk running at:", zap.String("host", integrationtestutils.GetConfigVariable("HOST")),
 		zap.String("uiPort", integrationtestutils.GetConfigVariable("UI_PORT")),

exporter/splunkhecexporter/package_test.go

@@ -0,0 +1,17 @@
+// Copyright The OpenTelemetry Authors
+// SPDX-License-Identifier: Apache-2.0
+
+package splunkhecexporter
+
+import (
+	"testing"
+
+	"go.uber.org/goleak"
+)
+
+// The IgnoreTopFunction call prevents catching the leak generated by opencensus
+// defaultWorker.Start which at this time is part of the package's init call.
+// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information.
+func TestMain(m *testing.M) {
+	goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"))
+}