[processor/groupbyattrs] move from OpenCensus to OpenTelemetry #30764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d8a6a0 to
fa1e603
Compare
d3ed055 to
7abf1e6
Compare
|
|
||
| it.mNumNonGroupedSpans = counter | ||
|
|
||
| histo, err := metadata.Meter(set).Int64Histogram( |
There was a problem hiding this comment.
maybe we could just call this histogram? :)
There was a problem hiding this comment.
i don't have a strong preference here, the codebase already has a mix of both histo and histogram
6d71567 to
c9f4576
Compare
TylerHelmuth
approved these changes
Jan 31, 2024
added 4 commits
February 1, 2024 09:43
Fixes open-telemetry#30763 Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
a9b42ac to
d089996
Compare
Signed-off-by: Alex Boten <aboten@lightstep.com>
d089996 to
377c3eb
Compare
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…telemetry#30764) Fixes open-telemetry#30763 --------- Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30763