Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] removed deprecated options gce, gke from the resourcedetection processor readme #30665

Conversation

mar4uk
Copy link
Contributor

@mar4uk mar4uk commented Jan 18, 2024

Description:
Some time ago gce and gke detectors were deprecated to use a single gcp detector.
This PR updates README to remove mentions of gce and gke detectors

@mar4uk mar4uk requested a review from a team January 18, 2024 13:53
@mar4uk mar4uk changed the title [chore] removed deprecated options gce, gke from the resourcedetection processor [chore] removed deprecated options gce, gke from the resourcedetection processor readme Jan 18, 2024
@github-actions github-actions bot added the processor/resourcedetection Resource detection processor label Jan 18, 2024
@dashpole
Copy link
Contributor

Thanks! I forgot to update the readme :)

@codeboten codeboten merged commit 9024ad8 into open-telemetry:main Jan 18, 2024
86 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 18, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
…n processor readme (open-telemetry#30665)

**Description:** <Describe what has changed.>
Some time ago `gce` and `gke` detectors were
[deprecated](open-telemetry#10347)
to use a single `gcp` detector.
This PR updates README to remove mentions of `gce` and `gke` detectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/resourcedetection Resource detection processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants