Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] move kafka exporter to generated lifecycle tests #30531

Merged
merged 3 commits into from
Mar 14, 2024
Merged

[chore] move kafka exporter to generated lifecycle tests #30531

merged 3 commits into from
Mar 14, 2024

Conversation

Frapschen
Copy link
Contributor

@Frapschen Frapschen commented Jan 13, 2024 •
edited by atoulme
Loading

Relates to #27849

@Frapschen Frapschen requested a review from a team January 13, 2024 07:20
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 28, 2024
@Frapschen Frapschen removed the Stale label Jan 29, 2024
mx-psi
mx-psi previously approved these changes Jan 29, 2024
View reviewed changes
@mx-psi mx-psi dismissed their stale review January 29, 2024 10:14

Didn't mean to approve this, sorry

@atoulme atoulme force-pushed the kafka_exporter_lifecycle branch from 451c7cd to f487167 Compare January 31, 2024 20:17
@github-actions github-actions bot requested a review from pavolloffay January 31, 2024 20:17
@atoulme
Copy link
Contributor

atoulme commented Jan 31, 2024

@pavolloffay and @MovieStoreGuy please review as codeowners. I have changed the start sequence of the exporter.

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 15, 2024
@atoulme atoulme removed the Stale label Feb 28, 2024
@MovieStoreGuy
Copy link
Contributor

I am nervous about moving the creation of the client within to Start mostly because it will need some locking and components are meant to be immutable once created (to a certain degree).

@atoulme atoulme force-pushed the kafka_exporter_lifecycle branch from f487167 to 7270a68 Compare March 1, 2024 16:40
@MovieStoreGuy
Copy link
Contributor

Happy with the changes, I just need the conflicts resolved before we can merge :)

@atoulme atoulme force-pushed the kafka_exporter_lifecycle branch from 7270a68 to ff2c123 Compare March 14, 2024 05:23
@atoulme atoulme added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels Mar 14, 2024
@atoulme atoulme force-pushed the kafka_exporter_lifecycle branch from ff2c123 to e861cfe Compare March 14, 2024 06:04
@MovieStoreGuy MovieStoreGuy merged commit b4965d2 into open-telemetry:main Mar 14, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 14, 2024
@Frapschen Frapschen deleted the kafka_exporter_lifecycle branch March 14, 2024 09:21
@crobert-1 crobert-1 mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme left review comments

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

@mx-psi mx-psi mx-psi left review comments

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

Assignees

@mx-psi mx-psi

Labels
exporter/kafka ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.97.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Frapschen @atoulme @MovieStoreGuy @mx-psi