[connector/datadog] Fix leaking goroutines and enable goleak #30500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
goleak
detected some leaking goroutines in this package. Some are due to issues we've already hit, some are actual leaks in the collector. The addedStop
calls for theTraceWriter
andStatsWriter
were required to make sure we don't leak goroutines on shutdown.Link to tracking Issue:
#30438
Testing:
goleak
test is passing. Calling theShutdown
methods in the test now take quite a while due to how many goroutines are creating when theTracesAgent
is created.Documentation:
Help on the changelog message is appreciated, not sure what details would make sense to users and what wouldn't.