[cmd/mdatagen] has been moved to opentelemetry-collector #30495
Conversation
Signed-off-by: Alex Boten <aboten@lightstep.com>
|
@atoulme do we have any contrib's exclusive functionality in mdatagen right now. If so, we need to think of wrapping core's version instead of removing the whole module. I do agree we should not keep a copy of it here |
|
We can probably keep mdatagen experimental features in contrib for now. But eventually, they should all be moved to core and we need to remove this module |
We do, quite a bit. All the test generation, I take it. As a matter of fact, the code changed today :) I certainly hope we will follow a mindful deprecation cycle of this code rather than deleting it outright, right? This deletion here doesn't address the go:generate instructions to generate code in modules, do we mean to add mdatagen through install_tools? |
I would expect this code to be moved to the core repo no?
Yes. That's the plan, this is still in draft. |
Yes, of course, since we're moving. But I'm pointing to the fact that per Go guidelines, we should first deprecate the package since it is published, see https://pkg.go.dev/github.com/AviatrixDev/opentelemetry-collector-contrib/cmd/mdatagen And given our rate of change with mdatagen, I'd certainly appreciate if we can sync up and make sure we don't miss anything in the move.
Nice! |
100% i opened this PR mostly not to forget to finish moving mdatagen :) |
|
Filing #30497 to follow up and keeping track |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…#31609) This change migrates `generate` make target from using the deprecated `cmd/mdatagen` in this repository to mdategen defined in core repository. To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and #21469 are resolved. Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: `awsproxy` and `jaegerremotesampling`. It's not a breaking change because the generated meter and tracer are not being used yet. This change unblocks #30495
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
…open-telemetry#31609) This change migrates `generate` make target from using the deprecated `cmd/mdatagen` in this repository to mdategen defined in core repository. To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolved. Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: `awsproxy` and `jaegerremotesampling`. It's not a breaking change because the generated meter and tracer are not being used yet. This change unblocks open-telemetry#30495
…open-telemetry#31609) This change migrates `generate` make target from using the deprecated `cmd/mdatagen` in this repository to mdategen defined in core repository. To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolved. Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: `awsproxy` and `jaegerremotesampling`. It's not a breaking change because the generated meter and tracer are not being used yet. This change unblocks open-telemetry#30495
Fixes #30497