[chore][Makefile] Fix make otel-from-tree #30333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Jan 9, 2024
dmitryax
approved these changes
Jan 10, 2024
|
Thanks @crobert-1! |
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> From testing I found out that golang's `replace` directive didn't work properly when using an absolute path with the `../` included. Using a relative path or an absolute path (without `../` in the middle) resolves the issue. The simple and most clear solution is to use a true absolute path, so I've used `dirname` with the repo's root dir to determine the parent dir. **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#30330 **Testing:** <Describe what testing was performed and which tests were added.> Commands in bug description are all working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
From testing I found out that golang's
replacedirective didn't work properly when using an absolute path with the../included. Using a relative path or an absolute path (without../in the middle) resolves the issue. The simple and most clear solution is to use a true absolute path, so I've useddirnamewith the repo's root dir to determine the parent dir.Link to tracking Issue:
Fixes #30330
Testing:
Commands in bug description are all working.