Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/alibabacloudlogservice] Upgrade code to adopt new aliyun-log-go-sdk version #30243

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

qiansheng91
Copy link
Contributor

Description:

Replace deprecated UpdateStsToken, AccessKeyID, and AccessKeySecret fields in ProducerConfig with CredentialsProvider

Link to tracking Issue:

#26456

@qiansheng91
Copy link
Contributor Author

Link to : #29721

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 2, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint

alibabacloudlogserviceexporter/uploader.go:58: File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

producerConfig.UpdateStsToken = tokenUpdateFunc
provider := sls.NewUpdateFuncProviderAdapter(tokenUpdateFunc)
producerConfig.CredentialsProvider = provider

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There no logical separation here

Suggested change

@dmitryax dmitryax changed the title Upgrade dependency [exporter/alibabacloudlogservice] Upgrade code to adopt new aliyun-log-go-sdk version Jan 10, 2024
@dmitryax dmitryax merged commit c5d9e98 into open-telemetry:main Jan 10, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 10, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
…g-go-sdk version (open-telemetry#30243)

**Description:** 

Replace deprecated UpdateStsToken, AccessKeyID, and AccessKeySecret
fields in ProducerConfig with CredentialsProvider

**Link to tracking Issue:** 

open-telemetry#26456
@qiansheng91 qiansheng91 deleted the feature/upgrade-libaray branch January 12, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/alibabacloudlogservice Alibaba components Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants