Update kubernetes packages to v0.29.0 #30087
Conversation
|
Looks like there are some some incompatible changes here. I'll try to take a look today. |
| @@ -44,7 +44,7 @@ type eventBroadcaster interface { | |||
| StartLogging(logf func(format string, args ...any)) watch.Interface | |||
| // NewRecorder returns an EventRecorder that can be used to send events to this EventBroadcaster | |||
| // with the event source set to the given event source. | |||
| NewRecorder(scheme *runtime.Scheme, source v1.EventSource) record.EventRecorder | |||
| NewRecorder(scheme *runtime.Scheme, source v1.EventSource) record.EventRecorderLogger | |||
There was a problem hiding this comment.
Fix for a breaking change: kubernetes/client-go@3595e52#diff-35acc6015fded274d91d420a4def1d1530a6b1cf62c7cb9143a8da3419413305
| @@ -84,12 +84,12 @@ func newK8sResolver(clt kubernetes.Interface, | |||
| epsListWatcher := &cache.ListWatch{ | |||
| ListFunc: func(options metav1.ListOptions) (runtime.Object, error) { | |||
| options.FieldSelector = epsSelector | |||
| options.TimeoutSeconds = pointer.Int64(1) | |||
There was a problem hiding this comment.
These functions were deprecated
There was a problem hiding this comment.
Thanks for the fixes @TylerHelmuth 👍🏻 looks like the current failure is unrelated https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7265548153/job/19795514227?pr=30087
|
Hey turns out that these new versions require Go 1.21:
We can't upgrade until we bump our go version. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
|
@TylerHelmuth can you file an issue similar to #20245? |
This PR contains the following updates:
v0.28.4->v0.29.0v0.28.4->v0.29.0v0.28.4->v0.29.0v0.28.4->v0.29.0Release Notes
kubernetes/api (k8s.io/api)
v0.29.0Compare Source
kubernetes/apimachinery (k8s.io/apimachinery)
v0.29.0Compare Source
kubernetes/client-go (k8s.io/client-go)
v0.29.0Compare Source
kubernetes/kubelet (k8s.io/kubelet)
v0.29.0Compare Source
Configuration
📅 Schedule: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.