Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] move azureblob receiver to generated lifecycle tests #30025

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[chore] move azureblob receiver to generated lifecycle tests #30025

merged 1 commit into from
Dec 18, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 18, 2023

Related to #27850

@atoulme atoulme requested a review from mx-psi as a code owner December 18, 2023 08:29
@atoulme atoulme requested a review from a team December 18, 2023 08:29
mx-psi
mx-psi reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am lacking context here so bear with me but, if we are moving the test shouldn't we be also removing the test from elsewhere? Also, I see the test is being skipped, do we have an issue about removing the SkipNow?

@codeboten
Copy link
Contributor

I am lacking context here so bear with me but, if we are moving the test shouldn't we be also removing the test from elsewhere? Also, I see the test is being skipped, do we have an issue about removing the SkipNow?

@mx-psi components are all automatically tested now in cmd/otelcontribcol (see https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/otelcontribcol/processors_test.go as an example)

Once all components have these tests generated, we'll be able to remove that component altogether. For components that skip lifecycle tests, i've been adding a new issue for each. See #29996 as an example

@bogdandrutu bogdandrutu merged commit 36f0477 into open-telemetry:main Dec 18, 2023
86 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 18, 2023
@mx-psi mx-psi mentioned this pull request Dec 18, 2023
Closed
@mx-psi
Copy link
Member

mx-psi commented Dec 18, 2023

I am lacking context here so bear with me but, if we are moving the test shouldn't we be also removing the test from elsewhere? Also, I see the test is being skipped, do we have an issue about removing the SkipNow?

@mx-psi components are all automatically tested now in cmd/otelcontribcol (see https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/otelcontribcol/processors_test.go as an example)

Once all components have these tests generated, we'll be able to remove that component altogether. For components that skip lifecycle tests, i've been adding a new issue for each. See #29996 as an example

Thanks, filed #30043

cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
@atoulme @cparkins
[chore] move azureblob receiver to generated lifecycle tests (open-te…
2650cdd 
…lemetry#30025)

Related to
open-telemetry#27850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi left review comments

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees

@bryan-aguilar bryan-aguilar

Labels
receiver/azureblob
Projects
None yet
Milestone
v0.92.0
Development

Successfully merging this pull request may close these issues.
5 participants
@atoulme @codeboten @mx-psi @bogdandrutu @bryan-aguilar