Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/bearertokenauthextension] Fix for extension Always return "401 Unauthorized" via HTTP connection #24656 #29992

Merged
merged 3 commits into from
Dec 21, 2023
Merged

[extension/bearertokenauthextension] Fix for extension Always return "401 Unauthorized" via HTTP connection #24656 #29992

merged 3 commits into from
Dec 21, 2023

Conversation

nagashan
Copy link
Contributor

Fix for extension Always return "401 Unauthorized" via HTTP connection #24656

Description: We are always trying to get the authorization with the lower case from headers, But The headers from Http is received as Authorization capitalcase even-though we sent in lower case.

Link to tracking Issue: <24656>

Testing: Tested in the local
Screenshot 2023-12-17 at 5 28 26 PM
Screenshot 2023-12-17 at 5 32 11 PM
Screenshot 2023-12-17 at 5 34 12 PM

@nagashan nagashan requested a review from jpkrohling as a code owner December 17, 2023 12:59
@nagashan nagashan requested a review from a team December 17, 2023 12:59
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from frzifus December 17, 2023 12:59
@nagashan nagashan mentioned this pull request Dec 17, 2023
Closed
@atoulme
Copy link
Contributor

atoulme commented Dec 17, 2023

Please run make chlog-new and fill the changelog entry for this issue. You can use the PR number as issue number.

@nagashan
Copy link
Contributor Author

Please run make chlog-new and fill the changelog entry for this issue. You can use the PR number as issue number.

Done

@nagashan @crobert-1
Update .chloggen/naga_fix_24656-http-bearertokenauth-401.yaml
54d0608 
Co-authored-by: Curtis Robert <crobert@splunk.com>
@nagashan
Copy link
Contributor Author

@atoulme Does this commits looks good? Any changes required?

atoulme
atoulme approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Could use a test but not a deal breaker

frzifus
frzifus approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nagashan, I agree with @atoulme a test would be great :)

@bogdandrutu bogdandrutu merged commit 94c4da0 into open-telemetry:main Dec 21, 2023
85 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 21, 2023
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
@nagashan @crobert-1 @cparkins
[extension/bearertokenauthextension] Fix for extension Always return …
f9e8bdc 
…"401 Unauthorized" via HTTP connection open-telemetry#24656 (open-telemetry#29992)

Fix for extension Always return "401 Unauthorized" via HTTP connection
open-telemetry#24656

**Description:** We are always trying to get the `authorization` with
the lower case from headers, But The headers from Http is received as
`Authorization` capitalcase even-though we sent in lower case.

**Link to tracking Issue:**
<[24656](open-telemetry#24656)>

**Testing:** Tested in the local
<img width="1060" alt="Screenshot 2023-12-17 at 5 28 26 PM"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/94837505/a7401d32-9ce2-4ac5-b4a4-94b43d1efcc8">
<img width="919" alt="Screenshot 2023-12-17 at 5 32 11 PM"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/94837505/b7778fc1-1dee-487a-8458-669b8bf5ec2e">
<img width="890" alt="Screenshot 2023-12-17 at 5 34 12 PM"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/94837505/369577d3-7ddf-45e9-be25-81e699e56e2a">

---------

Co-authored-by: Curtis Robert <crobert@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@frzifus frzifus frzifus approved these changes

@atoulme atoulme atoulme approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

Assignees

@bogdandrutu bogdandrutu

Labels
extension/bearertokenauth
Projects
None yet
Milestone
v0.92.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nagashan @atoulme @frzifus @crobert-1 @bogdandrutu