Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] remove sampling policy from logger #29886

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 14, 2023

Description:
Remove sampling policy from logger

Link to tracking Issue:
Fixes #23801

@atoulme atoulme requested a review from djaglowski as a code owner December 14, 2023 17:29
@atoulme atoulme requested a review from a team December 14, 2023 17:29
@bogdandrutu bogdandrutu merged commit 5ddd0ba into open-telemetry:main Dec 14, 2023
82 of 86 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 14, 2023
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
**Description:**
Remove sampling policy from logger

**Link to tracking Issue:**
Fixes open-telemetry#23801
@newly12
Copy link
Contributor

newly12 commented Jan 18, 2024

I noticed before when there are many filelog receiver created, the same number of loggers will be created by stanza package, which lead to a little more memory usage, I believe this PR would definitely help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/stanza] Reconsider aggresive sampling policy for logger
5 participants