Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Expose namedpipe config on all platforms #29857

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[chore] Expose namedpipe config on all platforms #29857

merged 1 commit into from
Dec 13, 2023

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Dec 13, 2023 •
edited
Loading

Fixes #29855

Follows pattern of #29754

@djaglowski djaglowski added the Run Windows Enable running windows test on a PR label Dec 13, 2023
@djaglowski djaglowski force-pushed the fix-namedpipe-windows branch from 7b7bc5f to 3c2c716 Compare December 13, 2023 16:38
@djaglowski djaglowski force-pushed the fix-namedpipe-windows branch from 3c2c716 to c326bc2 Compare December 13, 2023 17:00
@djaglowski djaglowski marked this pull request as ready for review December 13, 2023 17:35
@djaglowski djaglowski requested review from a team and dashpole December 13, 2023 17:35
songy23
songy23 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djaglowski djaglowski merged commit 95d75a6 into open-telemetry:main Dec 13, 2023
94 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 13, 2023
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
@djaglowski @cparkins
[chore] Expose namedpipe config on all platforms (open-telemetry#29857)
7d788f5 
Fixes
open-telemetry#29855

Follows pattern of
open-telemetry#29754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@atoulme atoulme

Labels
pkg/stanza receiver/namedpipe Run Windows Enable running windows test on a PR
Projects
None yet
Milestone
v0.92.0
Development

Successfully merging this pull request may close these issues.

Windows tests in main are failing
3 participants
@djaglowski @songy23 @atoulme