Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Try tuning some renovate bot things #29787

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Dec 12, 2023

Closes #29784

@TylerHelmuth TylerHelmuth requested review from a team and djaglowski December 12, 2023 17:29
@@ -8,7 +8,7 @@ on:
jobs:
add-owners-to-pr:
runs-on: ubuntu-latest
if: ${{ github.actor != 'dependabot[bot]' && github.repository_owner == 'open-telemetry' }}
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' && github.repository_owner == 'open-telemetry' }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the actor changes to opentelemetrybot when it pushes its commit. If this doesnt work we can try github.event.commits[0].author.name or github.event.pull_request.user.login.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as opentelemetrybot is guaranteed to run after renovate bot (which I believe is the case)

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 12, 2023
@TylerHelmuth TylerHelmuth merged commit 3844732 into open-telemetry:main Dec 12, 2023
89 of 90 checks passed
@TylerHelmuth TylerHelmuth deleted the tune-renovate-bot branch December 12, 2023 20:10
@github-actions github-actions bot added this to the next release milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renovatebot should not run CI checks on initial PR
4 participants