-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Try tuning some renovate bot things #29787
[chore] Try tuning some renovate bot things #29787
Conversation
@@ -8,7 +8,7 @@ on: | |||
jobs: | |||
add-owners-to-pr: | |||
runs-on: ubuntu-latest | |||
if: ${{ github.actor != 'dependabot[bot]' && github.repository_owner == 'open-telemetry' }} | |||
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' && github.repository_owner == 'open-telemetry' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the actor changes to opentelemetrybot when it pushes its commit. If this doesnt work we can try github.event.commits[0].author.name
or github.event.pull_request.user.login
.
b98a430
to
ba2a8e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as opentelemetrybot is guaranteed to run after renovate bot (which I believe is the case)
Closes #29784