[StatsD receiver]Add timing/histogram for statsD receiver as OTLP gauge #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6de5aa to
e29c81f
Compare
Codecov Report
@@ Coverage Diff @@
## main #2973 +/- ##
==========================================
+ Coverage 91.55% 91.57% +0.02%
==========================================
Files 465 467 +2
Lines 22848 22904 +56
==========================================
+ Hits 20918 20974 +56
Misses 1437 1437
Partials 493 493
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
925be24 to
e2108fd
Compare
JohnWu20
reviewed
Apr 5, 2021
jmacd
requested changes
Apr 5, 2021
|
Let me know if this forward-looking configuration support plan seems to much of a burden. I hope it's not! The functionality looks 💯. |
9c4291a to
44b91fd
Compare
jmacd
approved these changes
Apr 8, 2021
69883df to
69feb73
Compare
69feb73 to
d378f42
Compare
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
punya
pushed a commit
to punya/opentelemetry-collector-contrib
that referenced
this pull request
Jul 21, 2021
* Change With*Unmarshallers signatures; Rename variables in kafkaReceiverFactory * fix tests * rollback change to variables in kafkaReceiverFactory
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
* Change With*Unmarshallers signatures; Rename variables in kafkaReceiverFactory * fix tests * rollback change to variables in kafkaReceiverFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is for timing/histogram support using OTLP gauge without aggregation. StatsD receiver receives
msorhStatsD type and transfers to OTLP double gauge. We discussed this approach with community last month. Timing/histogram use OTLP gauge instead of OTLP histogram, because:I will implement timing/histogram using OTLP summary data type in the next PR. The user could choose using gauge or summary in config file after the next PR is ready.
Link to tracking Issue:
#2566
Testing:
Added unit tests.
Documentation: