Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Ottl validate path #29703

Closed
wants to merge 7 commits into from
Closed

[pkg/ottl] Ottl validate path #29703

wants to merge 7 commits into from

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Dec 8, 2023 •
edited
Loading

Related to #22744

@github-actions github-actions bot added pkg/ottl processor/transform Transform processor labels Dec 8, 2023
@TylerHelmuth TylerHelmuth mentioned this pull request Dec 8, 2023
Merged
TylerHelmuth added a commit that referenced this pull request Dec 12, 2023
@TylerHelmuth @evan-bradley
[pkg/ottl] Add private interface for path and key (#29704)
4beafed 
**Description:**
This is the first PR working towards
#22744.

It adds 2 new interfaces, `path` and `key`, that will be given to
contexts to use when interpreting the paths/keys passed from the
grammar. Eventually we'll be able to use the `isComplete` functions
during parsing to ensure that all parts of the path were used by the
context.

By the end of that issue we'll have removed all public API's of OTTL's
grammar, which is going to cause massive breaking changes to all our
contexts and huge PRs. To help decrease the amount of changes per PR
these new interfaces are not yet exported and not yet implemented. To
see them partially in use checkout
#29703.

**Link to tracking Issue:**

Related to
#22744

**Testing:**

Added unit tests

**Documentation:** <Describe the documentation added.>

I'll add godoc comments once these things are made public

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu will be requested when the pull request is marked ready for review bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley will be requested when the pull request is marked ready for review evan-bradley is a code owner

Assignees
No one assigned
Labels
pkg/ottl processor/transform Transform processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TylerHelmuth