[exporter/prometheus] Fix panic when mutating data #29608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The prometheus exporter hit a panic when accumulating
Delta
metrics intoCumulative
sums. This is because the exporter does not enable mutating data in its capability. This change enables the exporter to mutate data in a safe and supported way.Link to tracking Issue:
Fixed #29574
Testing
There are existing tests that hit the logic that was panicking, but the metrics are set to
StateMutable
in testing (which is the only way they can be created and setup for testing). I believe that means that before this change the tests were invalid (didn't represent reality), but after this change they'll properly represent the exporter's functionality.