Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][exporter/file] Do not leak temp files during tests #29554

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[chore][exporter/file] Do not leak temp files during tests #29554

merged 2 commits into from
Nov 30, 2023

Conversation

pjanotti
Copy link
Contributor

Description:
Tests are leaking temporary files since they were not created under the t.TempDir(). This change moves all temporary files to t.TemDir() and add the needed Shutdown and Close calls to ensure that the files are closed before the test clean-up.

Link to tracking Issue:
N/A

Testing:
Local Windows and Linux make of exporter\fileexporter

Documentation:
N/A

@pjanotti pjanotti requested review from a team and MovieStoreGuy November 29, 2023 03:55
@codeboten codeboten merged commit 451e539 into open-telemetry:main Nov 30, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 30, 2023
@pjanotti pjanotti deleted the fix-fileexporter-test-leaking-tmp-files branch November 30, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@atoulme atoulme atoulme approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy

Assignees

@dmitryax dmitryax

Labels
exporter/file
Projects
None yet
Milestone
v0.90.1
Development

Successfully merging this pull request may close these issues.
4 participants
@pjanotti @atoulme @codeboten @dmitryax