[chore][receiver/windowseventlog] Expose windowseventlogreceiver config on all platforms #29553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not opposed to the change but would point out that we use this same pattern for journald receiver, which only is valid on linux. I think we should make the same changes there if we accept this PR. |
djaglowski
approved these changes
Nov 29, 2023
djaglowski
pushed a commit
that referenced
this pull request
Dec 12, 2023
…forms (#29754) **Description:** Follow-up to [comment](#29553 (comment)) in #29553 that `journald` also had different configurations according to the GOOS specified at build time. The change moves some types to sources that are built for all OSes while preserving the behavior of the receiver. **Link to tracking Issue:** N/A **Testing:** Added factory tests that validate create and shutdown on all platforms. **Documentation:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Discovered via #29532 (comment). The receiver configuration is not the same between Windows and the other OSes. This is not the practice for other components and make hard to write utilities dealing with the configuration on multiple platforms.
The change moves some types to sources that are built for all OSes while preserving the behavior of the receiver.
Link to tracking Issue:
N/A
Testing:
Local Windows and Linux, plus CI on my fork.
Documentation:
N/A