Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kafkareceiver] Add metrics for unmarshal errors #29303

Merged

Conversation

thmshmm
Copy link
Contributor

@thmshmm thmshmm commented Nov 16, 2023

Description: Add three new metrics to report on unmarshal errors.

Link to tracking Issue: #29302

Testing:
Extension of existing tests as well as manual testing and querying of the added metrics.

Documentation:
n/a

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thmshmm thmshmm force-pushed the feature/kafkareceiver-unmarshal-metrics branch 2 times, most recently from 7111e2f to caa96bb Compare November 28, 2023 09:12
@atoulme
Copy link
Contributor

atoulme commented Nov 29, 2023

@MovieStoreGuy please review

@thmshmm thmshmm force-pushed the feature/kafkareceiver-unmarshal-metrics branch 3 times, most recently from d30b65c to c476aaf Compare December 13, 2023 08:27
@thmshmm thmshmm force-pushed the feature/kafkareceiver-unmarshal-metrics branch from c476aaf to dde2ebc Compare December 14, 2023 14:28
@thmshmm thmshmm force-pushed the feature/kafkareceiver-unmarshal-metrics branch from dde2ebc to 95acc47 Compare December 21, 2023 07:59
@dmitryax dmitryax merged commit a3011b5 into open-telemetry:main Dec 21, 2023
85 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 21, 2023
@thmshmm thmshmm deleted the feature/kafkareceiver-unmarshal-metrics branch January 3, 2024 10:09
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants