GCP exporters: add GCP otel team as code owners #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Mar 26, 2021
.github/CODEOWNERS
Outdated
Comment on lines
40
to
41
| exporter/stackdriverexporter/ @open-telemetry/collector-contrib-approvers @GoogleCloudPlatform/open-telemetry | ||
| exporter/googlecloudexporter/ @open-telemetry/collector-contrib-approvers @GoogleCloudPlatform/open-telemetry |
There was a problem hiding this comment.
I understand this, but not sure if github supports cross projects teams
There was a problem hiding this comment.
You are correct unfortunately: https://github.uint.cloudmunity/t/question-add-team-for-codeowners-from-other-organization/3069. I will revise this PR.
Codecov Report
@@ Coverage Diff @@
## main #2895 +/- ##
==========================================
- Coverage 91.38% 91.37% -0.01%
==========================================
Files 463 463
Lines 22837 22837
==========================================
- Hits 20870 20868 -2
- Misses 1470 1471 +1
- Partials 497 498 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Mar 26, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
* GCP exporters: add GCP otel team as code owners * List out cross-org team members explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.