-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/encoding] Introduce interfaces for encoding extensions #28688
Merged
dmitryax
merged 1 commit into
open-telemetry:main
from
dmitryax:introduce-extension-interfaces
Oct 30, 2023
Merged
[extension/encoding] Introduce interfaces for encoding extensions #28688
dmitryax
merged 1 commit into
open-telemetry:main
from
dmitryax:introduce-extension-interfaces
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
introduce-extension-interfaces
branch
from
October 30, 2023 06:31
34263f4
to
ad1091a
Compare
@dmitryax LGTM! Also, there are some checks/unittest failures in CI. |
VihasMakwana
approved these changes
Oct 30, 2023
dao-jun
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmitryax
force-pushed
the
introduce-extension-interfaces
branch
from
October 30, 2023 15:06
ad1091a
to
38e82e9
Compare
atoulme
reviewed
Oct 30, 2023
dmitryax
force-pushed
the
introduce-extension-interfaces
branch
from
October 30, 2023 15:14
38e82e9
to
7f3937a
Compare
atoulme
approved these changes
Oct 30, 2023
dmitryax
force-pushed
the
introduce-extension-interfaces
branch
4 times, most recently
from
October 30, 2023 20:04
600e22e
to
37a1f1f
Compare
dmitryax
force-pushed
the
introduce-extension-interfaces
branch
from
October 30, 2023 21:11
37a1f1f
to
f4f0a59
Compare
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…en-telemetry#28688) **Description:** We should have explicit interfaces for the encoding extensions, which should be used by the receivers/exporters instead of marshallers and unmarshallers **Link to tracking Issue:** open-telemetry#28686
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…en-telemetry#28688) **Description:** We should have explicit interfaces for the encoding extensions, which should be used by the receivers/exporters instead of marshallers and unmarshallers **Link to tracking Issue:** open-telemetry#28686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We should have explicit interfaces for the encoding extensions, which should be used by the receivers/exporters instead of marshallers and unmarshallers
Link to tracking Issue: #28686