Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/encoding] Introduce interfaces for encoding extensions #28688

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Oct 30, 2023

Description: We should have explicit interfaces for the encoding extensions, which should be used by the receivers/exporters instead of marshallers and unmarshallers

Link to tracking Issue: #28686

@VihasMakwana
Copy link
Contributor

@dmitryax LGTM! Also, there are some checks/unittest failures in CI.

Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax force-pushed the introduce-extension-interfaces branch from ad1091a to 38e82e9 Compare October 30, 2023 15:06
.github/CODEOWNERS Outdated Show resolved Hide resolved
@dmitryax dmitryax force-pushed the introduce-extension-interfaces branch from 38e82e9 to 7f3937a Compare October 30, 2023 15:14
@dmitryax dmitryax force-pushed the introduce-extension-interfaces branch 4 times, most recently from 600e22e to 37a1f1f Compare October 30, 2023 20:04
@dmitryax dmitryax force-pushed the introduce-extension-interfaces branch from 37a1f1f to f4f0a59 Compare October 30, 2023 21:11
@dmitryax dmitryax merged commit bbde47c into open-telemetry:main Oct 30, 2023
@github-actions github-actions bot added this to the next release milestone Oct 30, 2023
@dmitryax dmitryax deleted the introduce-extension-interfaces branch October 31, 2023 03:44
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…en-telemetry#28688)

**Description:** We should have explicit interfaces for the encoding
extensions, which should be used by the receivers/exporters instead of
marshallers and unmarshallers

**Link to tracking Issue:**
open-telemetry#28686
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…en-telemetry#28688)

**Description:** We should have explicit interfaces for the encoding
extensions, which should be used by the receivers/exporters instead of
marshallers and unmarshallers

**Link to tracking Issue:**
open-telemetry#28686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants