Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] Fix nil pointer dereference #27882

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[pkg/stanza] Fix nil pointer dereference #27882

merged 1 commit into from
Oct 20, 2023

Conversation

haoqixu
Copy link
Member

@haoqixu haoqixu commented Oct 20, 2023 •
edited
Loading

Description:
Copying reader with empty FlushState will cause a nil pointer dereference.

@haoqixu haoqixu requested a review from djaglowski as a code owner October 20, 2023 11:10
@haoqixu haoqixu requested a review from a team October 20, 2023 11:10
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 20, 2023
djaglowski
djaglowski approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @haoqixu

@djaglowski djaglowski merged commit da24c2b into open-telemetry:main Oct 20, 2023
87 of 88 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 20, 2023
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
@haoqixu @sigilioso
[pkg/stanza] Fix nil pointer dereference (open-telemetry#27882)
735bb2d 
**Description:** 
Copying reader with empty FlushState will cause a nil pointer
dereference.
@haoqixu haoqixu mentioned this pull request Nov 7, 2023
Closed
6 tasks
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@haoqixu @jmsnll
[pkg/stanza] Fix nil pointer dereference (open-telemetry#27882)
39f4b18 
**Description:** 
Copying reader with empty FlushState will cause a nil pointer
dereference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

Assignees

@dmitryax dmitryax

Labels
pkg/stanza Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.88.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haoqixu @djaglowski @dmitryax