-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/encodingextension]Introduce zipkin and otlp encoding extensions. #27564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using adding config.Validate
instead of doing the validation within Start.
It makes it easier to validate config with the collector's sub command.
…ev/zipkin_otlp_encoding
Good call - maybe I should close mine in favor of this one though, it looks better imo. |
Agree @atoulme. |
# Conflicts: # .github/dependabot.yml
@dao-jun thanks for the contribution. Can you please split the PR into 2 separate for zipkin and OTLP? |
OK, I‘ll do it |
…pen-telemetry#27877) Introduce zipkin encoding extension. For more context, see open-telemetry#27564
Introduce OTLP encoding extension. For more context, see #27564
…pen-telemetry#27877) Introduce zipkin encoding extension. For more context, see open-telemetry#27564
…-telemetry#27875) Introduce OTLP encoding extension. For more context, see open-telemetry#27564
…-telemetry#27875) Introduce OTLP encoding extension. For more context, see open-telemetry#27564
Description:
Introduce zipkin and otlp encoding extensions.
Link to tracking Issue:
#28686
Testing:
Unit tests.
Documentation: