Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/encodingextension]Introduce zipkin and otlp encoding extensions. #27564

Closed
wants to merge 22 commits into from

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Oct 9, 2023

Description:

Introduce zipkin and otlp encoding extensions.

Link to tracking Issue:

#28686

Testing:

Unit tests.

Documentation:

Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using adding config.Validate instead of doing the validation within Start.
It makes it easier to validate config with the collector's sub command.

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
extension/encoding/zipkinencodingextension/extension.go Outdated Show resolved Hide resolved
@dao-jun dao-jun requested a review from MovieStoreGuy October 11, 2023 11:38
@VihasMakwana
Copy link
Contributor

@dao-jun
@atoulme has a similar PR open for otlpencodingextension #27263.
We should keep only one PR for otlp I believe.

@atoulme
Copy link
Contributor

atoulme commented Oct 11, 2023

Good call - maybe I should close mine in favor of this one though, it looks better imo.

@VihasMakwana
Copy link
Contributor

Agree @atoulme.
This one also has a support for proto

@dmitryax
Copy link
Member

@dao-jun thanks for the contribution. Can you please split the PR into 2 separate for zipkin and OTLP?

@dao-jun
Copy link
Member Author

dao-jun commented Oct 20, 2023

@dao-jun thanks for the contribution. Can you please split the PR into 2 separate for zipkin and OTLP?

OK, I‘ll do it

@dao-jun dao-jun closed this Oct 20, 2023
dmitryax pushed a commit that referenced this pull request Oct 24, 2023
…27877)

Introduce zipkin encoding extension.
For more context, see
#27564
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
dmitryax pushed a commit that referenced this pull request Oct 27, 2023
Introduce OTLP encoding extension.
For more context, see
#27564
@dao-jun dao-jun deleted the dev/zipkin_otlp_encoding branch October 28, 2023 07:55
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants