Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StatsD receiver] Change OpenCensus type to OpenTelemetry type for statsD receiver #2733

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

gavindoudou
Copy link
Contributor

@gavindoudou gavindoudou commented Mar 18, 2021

Description:

  1. Change StatsD receiver to use OpenTelemetry type instead of OpenCensus type.
  2. Revise some typos in readme

Link to tracking Issue: #2732

Testing: revised unit tests

@gavindoudou gavindoudou requested a review from jmacd as a code owner March 18, 2021 00:15
@gavindoudou gavindoudou requested a review from a team March 18, 2021 00:15
@gavindoudou gavindoudou force-pushed the statsDOT branch 5 times, most recently from 6654958 to a3fca89 Compare March 18, 2021 01:08
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #2733 (1123208) into main (f8c550f) will increase coverage by 1.09%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2733      +/-   ##
==========================================
+ Coverage   90.53%   91.63%   +1.09%     
==========================================
  Files         444      446       +2     
  Lines       21984    22042      +58     
==========================================
+ Hits        19904    20198     +294     
+ Misses       1618     1379     -239     
- Partials      462      465       +3     
Flag Coverage Δ
integration 69.18% <ø> (?)
unit 90.56% <96.15%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/statsdreceiver/protocol/statsd_parser.go 98.14% <90.90%> (+0.12%) ⬆️
...eiver/statsdreceiver/protocol/metric_translator.go 100.00% <100.00%> (ø)
receiver/statsdreceiver/receiver.go 92.98% <100.00%> (-0.24%) ⬇️
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️
internal/common/testing/container/container.go 73.68% <0.00%> (ø)
...rometheusexecreceiver/subprocessmanager/manager.go 76.00% <0.00%> (+6.00%) ⬆️
exporter/signalfxexporter/dimensions/requests.go 92.15% <0.00%> (+9.80%) ⬆️
receiver/jmxreceiver/receiver.go 94.80% <0.00%> (+16.88%) ⬆️
receiver/dockerstatsreceiver/docker.go 92.30% <0.00%> (+39.05%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c550f...1123208. Read the comment docs.

@gavindoudou gavindoudou force-pushed the statsDOT branch 4 times, most recently from 1d0acba to 9759536 Compare March 18, 2021 03:08
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

receiver/statsdreceiver/protocol/statsd_parser.go Outdated Show resolved Hide resolved
@gavindoudou gavindoudou changed the title Change OpenCensus type to OpenTelemetry type for statsD receiver [StatsD receiver] Change OpenCensus type to OpenTelemetry type for statsD receiver Mar 18, 2021
@bogdandrutu bogdandrutu merged commit 3254370 into open-telemetry:main Mar 19, 2021
@gavindoudou gavindoudou deleted the statsDOT branch March 19, 2021 00:31
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants