Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

googlecloud: renamed stackdriver exporter to googlecloud (2 of 2) #2713

Merged
merged 5 commits into from
Mar 19, 2021
Merged

googlecloud: renamed stackdriver exporter to googlecloud (2 of 2) #2713

merged 5 commits into from
Mar 19, 2021

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Mar 16, 2021 •
edited
Loading

Description: add back deprecated stackdriverexporter which wraps googlecloudexporter from #2677.

Testing: Tested a config like this, which is working fine.

receivers:
  hostmetrics:
    collection_interval: 10s
    scrapers:
      cpu:

exporters:
  stackdriver:
    project: otel-starter-project
    use_insecure: false
  logging:
    loglevel: debug
    sampling_initial: 200
    sampling_thereafter: 1

processors:
  batch:

service:
  pipelines:
    metrics:
      receivers: [hostmetrics]
      processors: [batch]
      exporters: [stackdriver, logging]

Documentation:
Added readme with migration instructions to replacement googlecloudexporter

@aabmass aabmass force-pushed the rename-stackdriver-part2 branch from 4f9ea45 to 0d4a71e Compare March 16, 2021 17:41
@codecov
Copy link

codecov bot commented Mar 16, 2021 •
edited
Loading

Codecov Report

Merging #2713 (a3aae22) into main (f8c550f) will increase coverage by 1.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2713      +/-   ##
==========================================
+ Coverage   90.53%   91.56%   +1.02%     
==========================================
  Files         444      446       +2     
  Lines       21984    22075      +91     
==========================================
+ Hits        19904    20213     +309     
+ Misses       1618     1393     -225     
- Partials      462      469       +7
Flag Coverage Δ
integration 69.13% <0.00%> (?)
unit 90.49% <40.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/stackdriverexporter/factory.go 35.71% <35.71%> (ø)
cmd/otelcontribcol/components.go 87.50% <100.00%> (+0.15%) ⬆️
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️
internal/common/testing/container/container.go 73.68% <0.00%> (ø)
receiver/jmxreceiver/receiver.go 94.80% <0.00%> (+16.88%) ⬆️
receiver/dockerstatsreceiver/docker.go 92.30% <0.00%> (+39.05%) ⬆️
receiver/dockerstatsreceiver/receiver.go 96.72% <0.00%> (+47.54%) ⬆️
receiver/jmxreceiver/subprocess/subprocess.go 96.55% <0.00%> (+74.48%) ⬆️
receiver/redisreceiver/receiver.go 87.50% <0.00%> (+87.50%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c550f...a3aae22. Read the comment docs.

@aabmass aabmass force-pushed the rename-stackdriver-part2 branch from 0d4a71e to 99498a9 Compare March 16, 2021 21:32
@aabmass aabmass marked this pull request as ready for review March 16, 2021 21:35
@aabmass aabmass requested a review from a team March 16, 2021 21:35
@aabmass
Copy link
Member Author

aabmass commented Mar 16, 2021

cc @punya @dashpole

@aabmass aabmass force-pushed the rename-stackdriver-part2 branch from 99498a9 to dd50f9c Compare March 16, 2021 22:01
@aabmass aabmass force-pushed the rename-stackdriver-part2 branch from dd50f9c to f0cc87d Compare March 16, 2021 22:02
punya
punya approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@punya punya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

exporter/stackdriverexporter/factory.go Outdated Show resolved Hide resolved
exporter/stackdriverexporter/README.md Outdated Show resolved Hide resolved
exporter/stackdriverexporter/factory.go Show resolved Hide resolved
@aabmass @punya
Apply suggestions from code review
1dd4501 
Co-authored-by: Punya Biswal <punya@google.com>
@aabmass aabmass force-pushed the rename-stackdriver-part2 branch from 7e23e0d to 0a92f5e Compare March 17, 2021 17:15
@aabmass aabmass force-pushed the rename-stackdriver-part2 branch from 0a92f5e to b4e5f8d Compare March 17, 2021 17:15
@aabmass
Copy link
Member Author

aabmass commented Mar 18, 2021

@bogdandrutu good to merge?

@bogdandrutu bogdandrutu merged commit 48cbeb5 into open-telemetry:main Mar 19, 2021
@aabmass aabmass deleted the rename-stackdriver-part2 branch March 19, 2021 13:17
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
@aabmass @punya @pmatyjasek-sumo
googlecloud: renamed stackdriver exporter to googlecloud (2 of 2) (#2713
305e65a 
)

* add back deprecated stackdriverexporter which wraps googlecloudexporter

* use delegate

* Apply suggestions from code review

Co-authored-by: Punya Biswal <punya@google.com>

* Address punya's comment, log deprecation warning

Co-authored-by: Punya Biswal <punya@google.com>
punya pushed a commit to punya/opentelemetry-collector-contrib that referenced this pull request Jul 21, 2021
@bogdandrutu
Remove unused public constants (open-telemetry#2713)
e487ff1 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@bogdandrutu
Remove unused public constants (#2713)
ee21165 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@punya punya punya approved these changes

Assignees

@jrcamp jrcamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aabmass @punya @bogdandrutu @jrcamp