[exporter/splunkhec] Retain all otel attributes #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2712 +/- ##
==========================================
- Coverage 91.50% 91.50% -0.01%
==========================================
Files 441 441
Lines 21927 21930 +3
==========================================
+ Hits 20065 20066 +1
- Misses 1393 1394 +1
- Partials 469 470 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Previously we were stripping service.name and host.name since they have dedicated entries in HEC. However we now want to keep these so that service.name and host.name will match across logs, metrics, and traces.
tigrannajaryan
approved these changes
Mar 16, 2021
tigrannajaryan
approved these changes
Mar 16, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
Previously we were stripping service.name and host.name since they have dedicated entries in HEC. However we now want to keep these so that service.name and host.name will match across logs, metrics, and traces.
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were stripping service.name and host.name since they have
dedicated entries in HEC. However we now want to keep these so that
service.name and host.name will match across logs, metrics, and traces.